Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceManager: handle services as anonymous classes #32

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

Slamdunk
Copy link
Owner

No description provided.

@Slamdunk Slamdunk added the bug Something isn't working label Apr 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #32 (e103e1a) into master (c82c8d2) will decrease coverage by 1.78%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     45.78%   44.00%   -1.79%     
- Complexity      104      107       +3     
============================================
  Files            20       20              
  Lines           273      275       +2     
============================================
- Hits            125      121       -4     
- Misses          148      154       +6     
Impacted Files Coverage Δ
...minas/ControllerPluginClassReflectionExtension.php 0.00% <0.00%> (ø)
...AbstractPluginMethodDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
...bstractServiceGetterDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
...as/ServiceManagerGetDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
.../Rules/Laminas/ServiceManagerGetMethodCallRule.php 95.45% <0.00%> (-0.20%) ⬇️
src/Type/Laminas/PluginMethodReflection.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82c8d2...e103e1a. Read the comment docs.

@Slamdunk Slamdunk merged commit 7944d45 into master Apr 20, 2022
@Slamdunk Slamdunk deleted the anonymous_classes_as_service branch April 20, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants