jwaliszko#214 Concurrent validation using RequiredIfAttribute throws …

…NullReferenceException - fixing ExpressiveAttribute temporarily setting PropertyType to null on a shared attribute instance, causing other threads to throw NullReferenceException
SmartGuideApp · Apr 4, 2023 · ddb18d7 · ddb18d7
1 parent 33b2ffe
commit ddb18d7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/UoN.ExpressiveAnnotations.NetCore/Attributes/ExpressiveAttribute.cs b/src/UoN.ExpressiveAnnotations.NetCore/Attributes/ExpressiveAttribute.cs
@@ -288,7 +288,8 @@ protected override ValidationResult IsValid(object value, ValidationContext vali
 
         private void AdjustMemberName(ValidationContext validationContext) // fixes for: MVC <= 4 (MemberName is not provided), WebAPI 2 (MemberName states for display name)
         {
-            PropertyType = null; // reset value
+            if (PropertyType != null) return;
+
             if (validationContext.MemberName == null && validationContext.DisplayName == null)
                 return;