🐛 Remove websocket connections that have been closed in send_event #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a connection is not dropped gracefully its websocket stays in the connection list. This means that when `send_event` runs it throws an `IOError` when it gets to that connection, causing all subsequent sockets in the list to not receive updated events. This commit instead rescues the error and removes the closed websocket from the list of connections.
|
Added a changelog and merged. Will be included in next 1.3.1 release. Thanks a lot @ssgelm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a connection is not dropped gracefully its websocket stays in the connection list. This means that when
send_eventruns it throws anIOErrorwhen it gets to that connection, causing all subsequent sockets in the list to not receive updated events. This commit instead rescues the error and removes the closed websocket from the list ofconnections.