Relax dependencies 🔧 🍎 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Looks good to me, we would be pinned on minor version, leaving the patch version to whatever is the latest available. Approving, will just do a few quick tests when I have time this week to work on Smashing. But this one should be included in the next release, planned for this or the next week. Thanks @dylanratcliffe !
This should mean that people can upgrade gems more readily without requiring a new Smashing release
|
@dylanratcliffe I noticed Travis was not running. Had a bit of spare time during lunch time today, so migrated |
|
CI passed, merging 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes many of the dependencies that smashing has. This should allow users to upgrade dependant gems without requiring a release of smashing. A good example of where this is require is in #174
In #174 we need to upgrade to
thin>= 1.8.0in order to be able to compile it against XCode 12 however since Smashing was dependant on version~> 1.7.2that means we could only use releases that were>= 1.7.2and< 1.8.0i.e. we can't use the new version.This relaxes many dependencies to allow users to upgrade to new feature releases, but not to the next X (breaking) release. Given that breaking changes should require a major release as per semver we should expect that this wouldn't cause any issues.
I did have a look through the commit messages to see if there was any specific reason why the dependencies were so strict and couldn't find any. If there are good reasons though please let me know.