check agent id

Snowfork · Dec 6, 2024 · c236149 · c236149
1 parent f9b3fc2
commit c236149
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 8 deletions.
diff --git a/contracts/src/Assets.sol b/contracts/src/Assets.sol
@@ -280,7 +280,11 @@ library Assets {
     }
 
     // @dev Mint foreign token from Polkadot
-    function mintForeignToken(bytes32 foreignTokenID, address recipient, uint256 amount) external {
+    function mintForeignToken(address agent, bytes32 foreignTokenID, address recipient, uint256 amount) external {
+        AssetsStorage.Layout storage $ = AssetsStorage.layout();
+        if(agent != $.assetHubAgent) {
+            revert TokenMintFailed();
+        }
         address token = _ensureTokenAddressOf(foreignTokenID);
         Token(token).mint(recipient, amount);
     }

diff --git a/contracts/src/Gateway.sol b/contracts/src/Gateway.sol
@@ -227,7 +227,7 @@ contract Gateway is IGateway, IInitializable, IUpgradable {
                 success = false;
             }
         } else if (message.command == Command.MintForeignToken) {
-            try Gateway(this).mintForeignToken{gas: maxDispatchGas}(message.params) {}
+            try Gateway(this).mintForeignToken{gas: maxDispatchGas}(channel.agent, message.params) {}
             catch {
                 success = false;
             }
@@ -411,9 +411,9 @@ contract Gateway is IGateway, IInitializable, IUpgradable {
     }
 
     // @dev Mint foreign token from polkadot
-    function mintForeignToken(bytes calldata data) external onlySelf {
+    function mintForeignToken(address agent, bytes calldata data) external onlySelf {
         MintForeignTokenParams memory params = abi.decode(data, (MintForeignTokenParams));
-        Assets.mintForeignToken(params.foreignTokenID, params.recipient, params.amount);
+        Assets.mintForeignToken(agent, params.foreignTokenID, params.recipient, params.amount);
     }
 
     // @dev Transfer Ethereum native token back from polkadot

diff --git a/contracts/test/Gateway.t.sol b/contracts/test/Gateway.t.sol
@@ -901,7 +901,7 @@ contract GatewayTest is Test {
         vm.expectEmit(true, true, false, false);
         emit Transfer(address(0), account1, 1000);
 
-        MockGateway(address(gateway)).mintForeignTokenPublic(abi.encode(params));
+        MockGateway(address(gateway)).mintForeignTokenPublic(assetHubAgent, abi.encode(params));
 
         address dotToken = MockGateway(address(gateway)).tokenAddressOf(dotTokenID);
 
@@ -916,7 +916,16 @@ contract GatewayTest is Test {
 
         vm.expectRevert(Assets.TokenNotRegistered.selector);
 
-        MockGateway(address(gateway)).mintForeignTokenPublic(abi.encode(params));
+        MockGateway(address(gateway)).mintForeignTokenPublic(assetHubAgent, abi.encode(params));
+    }
+
+    function testMintFromParachainOtherThanAssetHubWillFail() public {
+        MintForeignTokenParams memory params =
+            MintForeignTokenParams({foreignTokenID: bytes32(uint256(1)), recipient: account1, amount: 1000});
+
+        vm.expectRevert(Assets.TokenMintFailed.selector);
+
+        MockGateway(address(gateway)).mintForeignTokenPublic(bridgeHubAgent, abi.encode(params));
     }
 
     function testSendRelayTokenToAssetHubWithAddress32() public {

diff --git a/contracts/test/mocks/MockGateway.sol b/contracts/test/mocks/MockGateway.sol
@@ -81,8 +81,8 @@ contract MockGateway is Gateway {
         this.registerForeignToken(params);
     }
 
-    function mintForeignTokenPublic(bytes calldata params) external {
-        this.mintForeignToken(params);
+    function mintForeignTokenPublic(address agent, bytes calldata params) external {
+        this.mintForeignToken(agent, params);
     }
 
     function transferNativeTokenPublic(bytes calldata params) external {