Downgrade Rust to 1.67.0

[doubledup]

Opened as a draft until it's successfully built locally.

This avoids an issue where the sign-ext WASM feature is enabled in Rust >= 1.70.0.

cargo-contract issue
rust issue

[claravanstaden]

🥳 Thanks @doubledup!

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +1.50 🎉

Comparison is base (cd9e049) 73.10% compared to head (b483682) 74.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   73.10%   74.61%   +1.50%     
==========================================
  Files          38       28      -10     
  Lines        1517     1292     -225     
  Branches       52        0      -52     
==========================================
- Hits         1109      964     -145     
+ Misses        388      328      -60     
+ Partials       20        0      -20     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ascjones]

You guys are using ink pallet-contracts? 👀

[doubledup]

1.69.0 gives the same opcode error. Trying 1.67.0 nightly...

[vgeddes]

You guys are using ink pallet-contracts? 👀

Hi @ascjones, nope we aren't using ink contracts. We were just referencing other projects which were also having issues with bleeding edge rust.

[vgeddes]

@yrong is this downgrade also fine for you? It seems all the eth light client checks above have passed.

[yrong]

is this downgrade also fine for you? It seems all the eth light client checks above have passed.

I can not reproduce the issue though. But since we've box wrapped PreparedPublicKey the previous issue paritytech/substrate#14075 does not block me anymore. So I'm fine if the downgrade can solve problem here.

[vgeddes]

As said on Slack, I want us to try 1.70 stable and see if that works for us.

[yrong]

I want us to try 1.70 stable and see if that works for us.

I did test with 1.70 stable and just work without problem. But as use-ink/cargo-contract#1139 suggested 1.69 maybe safer to start with.

[doubledup]

Closing this in favour of #855