feat: add support for additional text below the sidebar logo #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dziraf
reviewed
Aug 24, 2022
| @@ -55,7 +55,10 @@ const SidebarBranding: React.FC<Props> = (props) => { | |||
| /> | |||
| ) : <h1>{companyName}</h1>} | |||
| </StyledLogo> | |||
| ) | |||
| { branding.additionalText && | |||
| <span>{branding.additionalText}</span> | |||
There was a problem hiding this comment.
I'd use Text (import { Text } from '@adminjs/design-system). This uses AdminJS global styles.
| /** | ||
| * Optional additional text below the logo/companyName. | ||
| */ | ||
| additionalText?: string; |
There was a problem hiding this comment.
How about just adding NODE_ENV here:
https://github.com/SoftwareBrothers/adminjs/blob/master/src/frontend/components/app/version.tsx
if it's just to display the environment information?
We can also add additional option to branding but I'd use a different name like logoTitle, logoSubtitle, headerText, headerMessage, menuHeaderMessage, menuHeaderText which would indicate where it'll appear just by looking at it's name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to specify which environment our application is on. It felt like a good idea to make this generic and upstream the work rather than making a custom component.