Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.2 support #129

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Rails 5.2 support #129

merged 2 commits into from
Jun 20, 2018

Conversation

akhiln
Copy link
Contributor

@akhiln akhiln commented Jun 7, 2018

This fixes all the specs to support Rails 5.2 and Ruby 2.5. This also fixes any deprecation warnings raised for Rails 6.

@chhlga
Copy link
Contributor

chhlga commented Jun 13, 2018

Hi there. Thank you for contributing. Latest rails version support is essentially important for a gem.
Now I see travis-ci build failed. Could you fix it, and then I can review your changes.

@joshbuker joshbuker self-requested a review June 13, 2018 21:16
@Ch4s3
Copy link
Contributor

Ch4s3 commented Jun 20, 2018

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants