Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove publish_actions permission for facebook #139

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Remove publish_actions permission for facebook #139

merged 3 commits into from
Sep 21, 2018

Conversation

satoakick
Copy link
Contributor

In facebook, publish_actions permission has been deleted.
https://developers.facebook.com/docs/graph-api/changelog/breaking-changes?locale=en_US

So, it is not good that publish_actions still exists in template file.

Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a changelog entry.

@@ -119,7 +119,7 @@
# config.facebook.callback_url = "http://0.0.0.0:3000/oauth/callback?provider=facebook"
# config.facebook.user_info_path = "me?fields=email"
# config.facebook.user_info_mapping = {:email => "email"}
# config.facebook.access_permissions = ["email", "publish_actions"]
# config.facebook.access_permissions = ["email"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed permission was removed with no replacement.

@joshbuker joshbuker merged commit ee532c1 into Sorcery:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants