Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the generators to allow name spaced models to be passed in. #237

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

crimson-knight
Copy link
Contributor

Example: "ExampleNameSpace::User" parameter which will generate a table migration with "example_name_space_user" as the table name.

It's my first shot at helping out with some open source work, so I hope this is a useful starting contribution!

…ch as "ExampleNameSpace::User" parametere which will generate a table migration with "example_name_space_user" as the table name
Copy link
Contributor

@kentarohorie kentarohorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.
And I think this idea is good.

@kentarohorie
Copy link
Contributor

@athix Could you review this PR?

@joshbuker joshbuker merged commit 54ec819 into Sorcery:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants