Use ActiveRecord.timestamped_migrations #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to call `inject_sorcery_to_model` in the previous method, since the generators execute all public methods in order.
Replace ActiveRecord::Base.timestamped_migrations with the newer ActiveRecord.timestamped_migrations
|
👋 @joshbuker mind having a quick look? |
Remove duplicate method in InstallGenerator
|
Any updates on this? |
joshbuker
previously approved these changes
Mar 8, 2024
|
Thanks for checking this out @joshbuker! Any clue why the pipeline is failing? Doesn't seem related to my code 🤨 |
|
Looks like some version conflicts popped up? There's another PR fixing the test suite, I'll merge that into main and then into the PR and see if it resolves the issue. |
joshbuker
approved these changes
Mar 8, 2024
|
lol glad to catch you on mastodon. Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
ActiveRecord::Base.timestamped_migrationswith the newerActiveRecord.timestamped_migrationsInternally, current versions of Rails use this syntax: https://github.com/search?q=repo%3Arails%2Frails%20timestamped_migrations&type=code
Close #349, close #353