Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing facebook parser and change default parser to json #53

Merged

Conversation

tg90nor
Copy link
Contributor

@tg90nor tg90nor commented Mar 29, 2017

With Facebook deprecating version 2.2 of the Graph API, they now only return json access tokens.

See https://developers.facebook.com/docs/apps/changelog

[Oauth Access Token] Format - The response format of https://www.facebook.com/v2.3/oauth/access_token returned when you exchange a code for an access_token now return valid JSON instead of being URL encoded. The new format of this response is {"access_token": {TOKEN}, "token_type":{TYPE}, "expires_in":{TIME}}. We made this update to be compliant with section 5.1 of RFC 6749.

@joshbuker
Copy link
Member

joshbuker commented Mar 29, 2017

Going to use this PR to work on the facebook issue (and pull the relevant changes out of #51 and into here).

Closes #52

@joshbuker joshbuker changed the title Make facebook provider use json access token parser Allow changing facebook parser and change default parser to json Mar 29, 2017
@joshbuker joshbuker requested a review from Ch4s3 March 29, 2017 21:26
Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on athix/sorcery: testing/facebook-fix; should fix facebook without action (beyond updating to this version of sorcery) and allows setting parse for facebook via config.

@joshbuker
Copy link
Member

@Ch4s3 can you review / merge and release this pull request ASAP? Fixes users being unable to login via Facebook using Sorcery.

@5hanth
Copy link

5hanth commented Apr 1, 2017

@Ch4s3 @athix : guys! would be great if this is reviewed and merged ASAP.. thanks!

@joshbuker
Copy link
Member

Merging this into master, @Ch4s3 can you please cut a new release (0.10.4) when you get a chance?

@joshbuker joshbuker merged commit cef2ae2 into Sorcery:master Apr 10, 2017
@danReynolds
Copy link

If someone could cut a new release it'd be great to get this working on master. Thanks!

@joshbuker
Copy link
Member

joshbuker commented May 10, 2017

@danReynolds currently only @Ch4s3 has the ability to cut a new release, still waiting to hear back from them.

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants