-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing facebook parser and change default parser to json #53
Allow changing facebook parser and change default parser to json #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on athix/sorcery: testing/facebook-fix; should fix facebook without action (beyond updating to this version of sorcery) and allows setting parse for facebook via config.
@Ch4s3 can you review / merge and release this pull request ASAP? Fixes users being unable to login via Facebook using Sorcery. |
Merging this into master, @Ch4s3 can you please cut a new release (0.10.4) when you get a chance? |
If someone could cut a new release it'd be great to get this working on master. Thanks! |
Released |
With Facebook deprecating version 2.2 of the Graph API, they now only return json access tokens.
See https://developers.facebook.com/docs/apps/changelog
[Oauth Access Token] Format - The response format of https://www.facebook.com/v2.3/oauth/access_token returned when you exchange a code for an access_token now return valid JSON instead of being URL encoded. The new format of this response is {"access_token": {TOKEN}, "token_type":{TYPE}, "expires_in":{TIME}}. We made this update to be compliant with section 5.1 of RFC 6749.