Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging clones the source element creating a duplicate CSS ID #2093

Closed
vanboom opened this issue Oct 19, 2021 · 0 comments
Closed

Dragging clones the source element creating a duplicate CSS ID #2093

vanboom opened this issue Oct 19, 2021 · 0 comments

Comments

@vanboom
Copy link
Contributor

vanboom commented Oct 19, 2021

When a sortable element is picked up (dragged), the "ghost" element created has the same CSS ID in the DOM as the original element.

To Reproduce
Debugging is required to detect this...

  1. Start gragging an element.
  2. Notice the cloneEl element created within the _onDragStart function will have the same ID as the dragEl.

Expected behavior
A duplicate CSS ID should not be created.

Information
Easy to fix -- will submit a PR.
vanboom added a commit to vanboom/Sortable that referenced this issue Oct 19, 2021
@vanboom
Issue SortableJS#2093 remove ID from the cloned element prior to addi…
840f9ae 
…ng to the DOM.

We should not create a duplicate CSS ID.
owen-m1 added a commit that referenced this issue Dec 2, 2021
@owen-m1
Merge pull request #2094 from vanboom/master
8e8a107 
Issue #2093 remove ID from the cloned element prior to adding to the …
@owen-m1 owen-m1 closed this as completed Mar 20, 2022
@snyk-io snyk-io bot mentioned this issue May 21, 2024
Open
@nathonius nathonius mentioned this issue May 24, 2024
Open
@nathonius nathonius mentioned this issue Sep 7, 2024
Open
@zhibx zhibx mentioned this issue Sep 7, 2024
Open
@nathonius nathonius mentioned this issue Sep 23, 2024
Open
@shinehs shinehs mentioned this issue Oct 12, 2024
Open
@d3sca d3sca mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vanboom @owen-m1