Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scroll when dragging between two lists and no window scroll in FireFox #256

Closed
olalb opened this issue Feb 2, 2015 · 16 comments
Closed
Labels
bug enhancement Quality of life changes to existing features
Milestone

Comments

@olalb
Copy link

olalb commented Feb 2, 2015

I have two lists and when moving from one to another there's no scroll if the list is too big.
If I move from list 1 to list 2, and then move within list 2 the scroll works.

Also, using Firefox (35.0.1) there's no window scrolling.
The JS Bin example doesn't scroll for me either.
I have to use set height and hidden overflow to scroll the list once I've moved an item to it.

@RubaXa RubaXa added the bug label Feb 9, 2015
RubaXa added a commit that referenced this issue Feb 9, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 9, 2015

Try dev-branch.

@pitymaia
Copy link

I got the same problem with 2 lists on chromium and firefox.
Scroll only works correctly with the same list that the dragged item is. If I grab an item on right list to put on left list and try to scroll the left list, it makes only scroll the right list.

Some times it woks to scroll UP, but never to scroll down, and UP only work some times...

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 10, 2015

@pitymaia Did you try dev-branch?

@pitymaia
Copy link

Yes, i tried... but don't solve this issue to me when need to scroll down.
Up it goes better, normally both lists scroll UP together, but down it never works.

Both boxes have scroll bars, but only the box that I dragged the item from moves.

@RubaXa RubaXa added this to the v1.1.0 milestone Feb 11, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

@pitymaia Make an example on jsbin.com

@pitymaia
Copy link

Hi RubaXa, here is the link: http://jsbin.com/ginini/10/edit?output

I notice that in this example some times the scroll down works lot better if I put the mouse on the precise right place. Is better than what a got here, but I don't no why.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

@pitymaia This problem has been fixed into scroll-branch
But I see another problem, wrong scrolling when dragging between lists (Because it simply is not designed ;[).

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

@pitymaia Wow! Try again scroll-branch, example: http://jsbin.com/muramayogo/1/edit

@pitymaia
Copy link

Thanks, much better! Great improvement.

Unfortunately, if I try hard enough I still can make the wrong list scroll...
Also I didn't notice any change on mobile Chromium.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

Then I do not know how to help you, I do not see a problem.
P.S. On the touch-device not tested.

RubaXa added a commit that referenced this issue Feb 11, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 11, 2015

@pitymaia Chrome + emulate touch-events: http://recordit.co/F7W4YKiq6D

@RubaXa RubaXa added the enhancement Quality of life changes to existing features label Feb 12, 2015
@pitymaia
Copy link

It is working, not perfect as it will be if this is designed to do this, but is working nice enough and I will use it. Your project is the best for drag and drop.
On mobile I tested your example again and is working perfect. I think I got a cache problem last time I tried to test it.

I think the use I make of your sortable is a nice future improvement to give a "polish", maybe there is a way yo detect the different drop areas to scroll only the one we are hover and to deactivate the scroll on the others one. I look the code you change to see if I can do some thing to help, but I really not experience enough to deal with.

Thanks a lot for all the help and congratulations for your work on this amazing project.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 12, 2015

@pitymaia To disable scrolling on one of the lists: scroll: false (at the desired list)

@pitymaia
Copy link

RubaXa , it all working very nice today. All tests I run here show a very good behaviour. I test with big lists of 500 items and works great.
Thanks again.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 12, 2015

Cool ;]

@RubaXa RubaXa closed this as completed Feb 12, 2015
@sharjeel-ahmed
Copy link

I took the latest code, when there is a list one below other, and when i drag from the top list to the below list, the entire page should scroll so that i can move it to the bottom list. I also set scroll:true, not sure if this scenario is fixed in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Quality of life changes to existing features
Projects
None yet
Development

No branches or pull requests

4 participants