Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use react-dom #754

Closed
wants to merge 1 commit into from
Closed

Updated to use react-dom #754

wants to merge 1 commit into from

Conversation

dmongeau
Copy link

No description provided.

@RubaXa
Copy link
Collaborator

RubaXa commented Jan 25, 2016

  1. What about those who use 0.13 and below?
  2. Wrong code-style.

@dmongeau
Copy link
Author

You don't plan to do a version compatible with react-dom, and therefore not compatible with 0.13?

@jimmiebtlr
Copy link

Wouldn't best practice in the react community be to always run the latest stable react version?

I'm also running into this.

@wrick17
Copy link

wrick17 commented Apr 25, 2016

@RubaXa now that findDOMNode and getDOMNode is deprecated in react 15, the code breaks. I had to manually change the mixin to ReactDOM to get it working. Its high time we move on to react-dom 😄

@combatpoodle
Copy link

combatpoodle commented May 24, 2016

Adding

{
    "peerDependencies": {
        "react": ">=15.0
    }
}

would resolve the compatibility concern above. Having this merged in would fix React-Photonkit (in addition to being much appreciated)

Thanks!

combatpoodle added a commit to combatpoodle/react-photonkit that referenced this pull request May 24, 2016
@wrick17
Copy link

wrick17 commented Jun 2, 2016

@israelshirk job well done 👍

@RubaXa RubaXa closed this Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants