Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model on the event gets stuck to item moved to/from nested list #46

Open
filipkis opened this issue Mar 15, 2019 · 0 comments
Open

Model on the event gets stuck to item moved to/from nested list #46

filipkis opened this issue Mar 15, 2019 · 0 comments

Comments

@filipkis
Copy link

filipkis commented Mar 15, 2019

I've discovered another bug with the case of nested list.

If we consider the list like this

  • item 1
    • subitem 1
  • item 2
  • item 3

As long as you move items in the main list all will be fine. However, once you move item (e.g. item 2) to nested list all following moves will have event.model set to item 2. In other words, if you then try to move item 3 above item 1 the move will succeed, however in callbacks (e.g. onEnd) the event.model will be wrong.

The same is true if the first action is moving an item from from the nested list (e.g. subitem 1). All following moves will have subitem 1 set as the model.

Here's minimal codepen showing the problem.

filipkis added a commit to filipkis/angular-legacy-sortablejs that referenced this issue Mar 15, 2019
filipkis added a commit to filipkis/angular-legacy-sortablejs that referenced this issue Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant