Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Switch for disabling/enabling auto play (continous play) #278

Closed
ghost opened this issue Jul 10, 2015 · 19 comments
Closed

[FEATURE] Switch for disabling/enabling auto play (continous play) #278

ghost opened this issue Jul 10, 2015 · 19 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jul 10, 2015

I really would like to see a button which disables the auto play of the next song. Or can anyone tell me, where I can edit this in the code?

@ghost ghost changed the title Switch for disabling/enabling auto play (continous play) [FEATURE] Switch for disabling/enabling auto play (continous play) Jul 10, 2015
@weblancaster
Copy link
Member

@eigenstil I'm working on some improvements on the Queue list when that's done.. your request will also be added.

@ghost
Copy link
Author

ghost commented Jul 10, 2015

Great – thanks for your feedback! really looking forward

@weblancaster
Copy link
Member

Hey @eigenstil can you explain a bit better what do you want please.. Isn't this just a repeat track feature? if so it's added #292

@Chriz007
Copy link

Chriz007 commented Sep 9, 2015

@weblancaster I made a video explaining that http://sendvid.com/r6uqd9dd

@Chriz007
Copy link

Chriz007 commented Sep 9, 2015

This video is ALSO a perfect example. Pretend the link I sent you for the video is a track being played. Once its over, there is an option to have a repeat button on the bottom left corner. But in this case, we want it to be played automatically. Just like on another music player like iTunes.
screen shot 2015-09-09 at 3 51 48 pm

itunes-12-shuffle-and-repeat

@weblancaster
Copy link
Member

Let's see what @eigenstil has to say @Chriz007

@Pitros
Copy link
Contributor

Pitros commented Sep 10, 2015

He doesn't want repeat function, the option he wants looks like that:
He clicks on track A, track is being played and when it's finished next one let's say B is not being played automatically. As well track A is not being repeated, no sound is being played at all.
Obviously he want to have an ability to enable or disable that option.
There's no hidden magic. Really.

@ghost
Copy link
Author

ghost commented Sep 10, 2015

Yes, @Pitros and @Chriz007 this is exactly what I mean! If a track has played to the und, I dont want anything to happen: neither repeat nor the next track. Actually this is the standard behaviour of ALL music playing apps (iTunes, windows media player, VLC player, winamp etc. etc.).

SoundCloud built this feature into their site and I find this very annoying. Thus, I was searching for an alternative.

@weblancaster
Copy link
Member

Ok @eigenstil we will implement that and release soon.

@weblancaster weblancaster self-assigned this Sep 10, 2015
weblancaster added a commit that referenced this issue Sep 10, 2015
add lock track feature. closes #278
@weblancaster
Copy link
Member

This was added. Will be available in the next release. thanks @eigenstil

@ghost
Copy link
Author

ghost commented Sep 10, 2015

Great, thanks! Really looking forward for the release
+4915771895665
von unterwegs gesendet
Am 10.09.2015 7:15 nachm. schrieb Michael Lancaster [email protected]:This was added. Will be available in the next release. thanks @eigenstil

—Reply to this email directly or view it on GitHub.

@weblancaster
Copy link
Member

Published the new version containing this issue

@ghost
Copy link
Author

ghost commented Sep 17, 2015

I just downloaded the newest windows-Version from the homepage via this link: http://goo.gl/Y46Hn8

But I'm not able to find the switch for disabling "auto-play of the next track". Where do I find this option? I clicked on the settings icon in the upper right, but this shows me only the "About" information.

Am I missing something or do I have to download something else?

@weblancaster
Copy link
Member

it's the same repeat button.. one click for repeat then another click to lock (you will see the number 1) when enabled to not play next or prev

@ghost
Copy link
Author

ghost commented Sep 17, 2015

But then, this track is played over and over again - this is not what I was asking for.

I want the player to STOP playing, when the song is over! This is what @Pitros already stated in his comment: #278 (comment)

I'm really sorry, if I didn't explain it well :-(

@weblancaster
Copy link
Member

Yes, that's what is happening.. the song stop playing.

take a look at the screenshot.. look the icons with number 1 ( which says that it's going to play one time)..also look that the song is done.. no song is played or over again.

I said one click on the icon for repeat then if you click again you enter in the lock mode which doesn't play next or over.

screen shot 2015-09-17 at 2 04 32 pm

@ghost
Copy link
Author

ghost commented Sep 17, 2015

Well – you are totally right. It stopps playing when the "1" is activated - I'm sorry.

BUT: I did not try this because the UI is totally confusing. In all other players that I know (VLC, winamp, itunes, windows media player), the small "1" next to the button means, that repeat is activated, and only one song (e.g. the already playing song) is repeating.

The better solution for the UI would be to have a switch/checkbox/etc. in the options in the upper right, to just toggle "continous play" (or whatever one may call it), which is the standard behaviour in the app. This way probably 90% of the users who are not like me (who wants only one single track to play), won't get confused by the UI ;-)

@Pitros
Copy link
Contributor

Pitros commented Sep 17, 2015

@weblancaster Yep that's true, that small 1 from UI/UX side is totally bad. I only know what it mean because I'm checking all issues and PRs. But in most players it would mean
a) track is going to repeated once then playback continues
b) every track is being repeated before next track will be played
IMHO that needs to be changed.

@weblancaster
Copy link
Member

I opened a issue #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants