Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

think this will allow for more playlists to load #605 #620

Merged
merged 2 commits into from
Feb 19, 2016

Conversation

cenderin
Copy link
Contributor

@cenderin cenderin commented Feb 4, 2016

#605 Increased playlist fetch limit, not really able to test this as I don't have a lot of playlists. But setting this value to 1 or something limits the playlists fetched so it seems like it would work...

@jakejarrett
Copy link
Member

@cenderin I can't test this code as i don't have any playlists

I'm pretty sure setting the limit to 125 would load 125 playlists on the first page? I'm not 100% sure though

@ghost
Copy link

ghost commented Feb 19, 2016

Can't you make a script to make a lot of playlists?
Op 19 feb. 2016 10:50 schreef "Jake Jarrett" [email protected]:

@cenderin https://github.com/cenderin I can't test this code as i don't
have any playlists

I'm pretty sure setting the limit to 125 would load 125 playlists on the
first page? I'm not 100% sure though


Reply to this email directly or view it on GitHub
#620 (comment)
.

@weblancaster
Copy link
Member

Hah, jesus this is a lot of playlists.. I think this is a good start isn't breaking anything but I can't test as well because I have ONE playlist.

I will merge and see what happen when we release

weblancaster added a commit that referenced this pull request Feb 19, 2016
think this will allow for more playlists to load #605
@weblancaster weblancaster merged commit a1c5f33 into Soundnode:master Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants