mpris Integration #645
mpris Integration #645
Conversation
|
@weblancaster this should work "as is", as i'd assume someone with the source code on linux should have git installed, But it can wait until the npm package gets updated with the patch if needed. |
|
This is ready to be tested on OS X / Windows if anyone wants to test it 👍 |
|
Anything special I should do to test this? what should I look for @jakejarrett |
|
@weblancaster mainly playing/pausing/next/pause & building, it should act as if nothing has changed from the master for any OS besides linux. |
|
Tested a build on windows, It won't build on systems without dbus headers present (dbus.h) Will try and solve this over the weekend @weblancaster (preferably without adding dbus as a requirement) |
|
When can we expect this PR to be on a release? Can't find it in 0.6.4. |
|
@dn5 waiting for node-dbus/119 so cross platform support is preserved |
|
@jakejarrett If you use my fork of |
|
@MarshallOfSound Thanks! This appears to have fixed a fair few of the bugs i was encountering haha. |
|
@jakejarrett My patched repo also contains patched versions of the |
jakejarrett
force-pushed
the
mpris
branch
2 times, most recently
from
d6ed748 to
1930d9f
Compare
jakejarrett
force-pushed
the
mpris
branch
2 times, most recently
from
5a34698 to
378e690
Compare
|
Thanks @MarshallOfSound this builds perfectly on windows! 😸 |
|
I'm going to test this tomorrow. |
|
@weblancaster any updates? |
ghost
mentioned this pull request
|
@weblancaster This builds & works on all supported platforms. Should be good to merge! 👍 |
jakejarrett
force-pushed
the
mpris
branch
3 times, most recently
from
68098dc to
03dae87
Compare
Added some abstracted functionality so we don't define 4 of the same if statements Added proper stop functionality (Set time to 0 & Pause) Moved mpris keypress events into playerCtrl instead of playerService. Fixed grunt shell for non-linux os' This should be much easier to follow whats going on.
|
Merging this, as i believe this is good to merge & it works fine on all platforms. |
|
Great job guys! 👍 |
|
Can someone package this as a release? Arch linux user here -- Our package manager source builds from the releases of this repo. Thanks 👍 |
|
My media key for play/pause won't work with Soundnode. I have a MS Natural 4000 keyboard. How do I find out whether mpris is working or not? I have version 0.6.5. from the app repository. |
|
@easterwood the latest version on Linux has a bug and users aren't being able to play songs. Now if you are on another OS you should be able to use the media keyboard as long you don't have any other application that makes use of the media keyboard. |
This adds media key support to linux (32/64bit)
It will remove the existing dbus-node folder from mpris-service's node_modules and then replace it with a patched version that supports nw0.12.3 then builds it. This will be simplified when upstream dbus-node gets patched too.
It currently won't support all the mpris features due to #639, but for now It only provides media key support 😸