Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clang #4

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: add clang #4

merged 1 commit into from
Nov 22, 2024

Conversation

@dj8yfo dj8yfo marked this pull request as ready for review November 21, 2024 15:22
@Canvinus
Copy link
Contributor

Do we also need clang for the cargo-near-commit Dockerfile?

Copy link

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under assumption that Rustup ships clang as well since it heavily uses LLVM and it would make sense to use the matching LLVM for C dependencies, but it is not the case: rust-lang/rust#56371

@dj8yfo @Canvinus we may also consider adding clang++ (for C++ modules), though I cannot think of contract dependencies that would require C++ (in non-contract environment, there is only one C++ dependency that I know - RocksDB)

@race-of-sloths score 3

@race-of-sloths
Copy link

race-of-sloths commented Nov 22, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Great job! Usain Bolt jealous of your results!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 3

Your contribution is much appreciated with a final score of 3!
You have received 35 (30 base + 15% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@Canvinus Canvinus merged commit 51b7235 into SourceScan:main Nov 22, 2024
@dj8yfo dj8yfo deleted the add_clang branch December 6, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image missing clang
4 participants