Fix app shutdown

SourceWriters · Jun 23, 2022 · 665ecf7 · 665ecf7
1 parent d3d11aa
commit 665ecf7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>net.sourcewriters.minecraft</groupId>
 	<artifactId>vcompat-updater</artifactId>
-	<version>1.0.2</version>
+	<version>1.0.3</version>
 	<name>vCompatUpdater</name>
 	<distributionManagement>
 		<repository>

diff --git a/src/main/java/net/sourcewriters/minecraft/vcompat/updater/CompatUpdater.java b/src/main/java/net/sourcewriters/minecraft/vcompat/updater/CompatUpdater.java
@@ -134,16 +134,19 @@ public void register(CompatApp app) {
 
     public void unregister(CompatApp app) {
         String id = app.getId();
-        if (id == null || !isRegistered(id)) {
-            app.onShutdown();
-            app.state = AppState.NONE;
-            return;
-        }
-        write.lock();
         try {
-            apps.remove(id);
+            if (id == null || !isRegistered(id)) {
+                return;
+            }
+            write.lock();
+            try {
+                apps.remove(id);
+            } finally {
+                write.unlock();
+            }
         } finally {
-            write.unlock();
+            app.onShutdown();
+            app.state = AppState.NONE;
         }
         read.lock();
         try {