Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting db connection from config #3497

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Allow setting db connection from config #3497

merged 4 commits into from
Jan 19, 2022

Conversation

hulkur
Copy link
Contributor

@hulkur hulkur commented Jan 19, 2022

1️⃣ Why should it be added? What are the benefits of this change?
It allows setting db connection from config instead of forcing default connection.
For multi-connection applications.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.

3️⃣ Does it include tests, if possible?
No tests included.
Tried but failed to get second connection to work in test setup.
Verified on actual application.
All existing tests pass.

4️⃣ Any drawbacks? Possible breaking changes?
No. Default config is set to work as before.

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@patrickbrouwers patrickbrouwers merged commit 6f6ac07 into SpartnerNL:3.1 Jan 19, 2022
@patrickbrouwers
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants