Allow setting db connection from config #3497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ Why should it be added? What are the benefits of this change?
It allows setting db connection from config instead of forcing default connection.
For multi-connection applications.
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible?
No tests included.
Tried but failed to get second connection to work in test setup.
Verified on actual application.
All existing tests pass.
4️⃣ Any drawbacks? Possible breaking changes?
No. Default config is set to work as before.
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌