Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting default_ttl #3980

Merged

Conversation

cosmastech
Copy link
Contributor

@cosmastech cosmastech commented Aug 13, 2023

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?
Our database had 1+ million cached entries with 'phpspreadsheet.' as the prefix. For all of them, their TTL was set to -1, so they never expired. It looks like the way Illuminate's Cache Repository works, it will rely on the library's default setting.

I doubt there's ever much of a reason to have a default TTL of forever on cell cache, but to avoid a big breaking change, I took the approach that I did.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Yes.

4️⃣ Any drawbacks? Possible breaking changes?
I don't think there's any drawback here. It would seem to me that we probably would want a more sensible default other than null, but given that this is the current behavior and a minor release, I just left the default as null.

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@cosmastech cosmastech marked this pull request as draft August 13, 2023 16:00
@cosmastech cosmastech marked this pull request as ready for review August 14, 2023 16:21
@stale stale bot added the stale label Oct 13, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this Oct 15, 2023
@cosmastech
Copy link
Contributor Author

I think this is still a bug and should be reopened.

@stale stale bot removed the stale label Oct 17, 2023
config/excel.php Outdated Show resolved Hide resolved
@patrickbrouwers patrickbrouwers merged commit 784cfbe into SpartnerNL:3.1 Oct 26, 2023
15 checks passed
@ngiraud ngiraud mentioned this pull request Oct 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants