-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting default_ttl #3980
Merged
patrickbrouwers
merged 15 commits into
SpartnerNL:3.1
from
cosmastech:feature/configure-cache-default-ttl
Oct 26, 2023
Merged
Allow setting default_ttl #3980
patrickbrouwers
merged 15 commits into
SpartnerNL:3.1
from
cosmastech:feature/configure-cache-default-ttl
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
I think this is still a bug and should be reopened. |
patrickbrouwers
requested changes
Oct 26, 2023
patrickbrouwers
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
Our database had 1+ million cached entries with 'phpspreadsheet.' as the prefix. For all of them, their TTL was set to -1, so they never expired. It looks like the way Illuminate's Cache Repository works, it will rely on the library's default setting.
I doubt there's ever much of a reason to have a default TTL of forever on cell cache, but to avoid a big breaking change, I took the approach that I did.
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
Yes.
4️⃣ Any drawbacks? Possible breaking changes?
I don't think there's any drawback here. It would seem to me that we probably would want a more sensible default other than
null
, but given that this is the current behavior and a minor release, I just left the default asnull
.5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌