Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added withSkipDuplicates import concern #4152

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

frknakk
Copy link
Contributor

@frknakk frknakk commented Jun 19, 2024

1️⃣ Why should it be added? What are the benefits of this change?
Allow skipping duplicate rows on single and batch inserts using insertOrIgnore method. Good for use cases where files could be imported multiple times and only a simple duplicate check is needed. In my project i had some quality and performance issues when using upsert for this use case.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
Yes

4️⃣ Any drawbacks? Possible breaking changes?
No

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

@stale stale bot added the stale label Aug 18, 2024
@patrickbrouwers patrickbrouwers merged commit bd95c9a into SpartnerNL:3.1 Aug 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants