Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Could not find zip member error on Serverless env #4198

Merged
merged 5 commits into from
Sep 7, 2024

Conversation

jbajou
Copy link
Contributor

@jbajou jbajou commented Sep 3, 2024

1️⃣ Why should it be added? What are the benefits of this change?
As mentioned here PR 4034 introduced an issue on Vapor.
Exports can't run as they fail with error

Could not find zip member zip:///tmp/laravel-excel-OrUefjdHl3lJ6LOvPp1RUrGwetvZuKEg.xlsx#_rels\.rels

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Only this

3️⃣ Does it include tests, if possible?
No test as I could not find much testing about this class either way

4️⃣ Any drawbacks? Possible breaking changes?
I don't think so

5️⃣ Mark the following tasks as done:

  • [x ] Checked the codebase to ensure that your feature doesn't already exist.
  • [x ] Take note of the contributing guidelines.
  • [x ] Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌
thanks

@patrickbrouwers
Copy link
Member

Waiting for confirmation of other people using Vapor that this fix works for them too

@patrickbrouwers patrickbrouwers merged commit 18495a7 into SpartnerNL:3.1 Sep 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants