Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check for empty SID parameter #42

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Add additional check for empty SID parameter #42

merged 1 commit into from
Aug 26, 2016

Conversation

mbrancato
Copy link
Contributor

@mbrancato mbrancato commented Aug 26, 2016

This is to fix an issue similar to issue #38, but at a different location. I ran into this error trying to run Get-BloodHoundData on a medium-sized domain.

WARNING: The pipeline has been stopped.
Convert-SidToName : Cannot validate argument on parameter 'SID'. The argument "" does not match the "^S-1-." pattern. Supply an argument that matches "^S-1-." and try the command again.
At C:\Users\superadmin\BloodHound.ps1:14556 char:55

  •         $MemberSimpleName = Convert-SidToName -SID <<<<  $Object.ObjectSID | Convert-ADName -InputType 'NT4' -OutputType 'Canonical'
    
    • CategoryInfo : InvalidData: (:) [Convert-SidToName], ParameterBindingValidationException
    • FullyQualifiedErrorId : ParameterArgumentValidationError,Convert-SidToName

@rvazarkar rvazarkar merged commit 3d3576b into SpecterOps:master Aug 26, 2016
@rvazarkar
Copy link
Contributor

Thanks for this!

porterhau5 pushed a commit to porterhau5/BloodHound that referenced this pull request Oct 22, 2017
Add additional check for empty SID parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants