Fix XSS by rewriting help text modals as JSX components #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #338 Co-authored-by: Jan Kruse <[email protected]>
|
Wow! This is awesome! We're currently working on the 4.2 branch, so I'm going to try and rebase this against there to make sure it gets in that release. Thanks for this awesome work, and for saving me a bunch of time. |
|
Thanks so much for the MR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #338, BloodHound currently contains a cross-site scripting vulnerability (XSS). The underlying reason is that help text modals are composed using template strings, which are prone to XSS vulnerabilities. The most thorough mitigation is to use JSX components instead. In order to spare @rvazarkar some effort, we therefore rewrote the help text modals as JSX components.
Furthermore, this commit fixes a few formatting errors in PowerShell scripts, such as wrong quotation marks and missing backslash escapes.
Closes #338