Add IO logging for Nassau quasi-inverses #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalcde
reviewed
Jul 3, 2022
|
I'll also add that since this PR gives a much more verbose log than previously, it might be a good idea to start using something like |
|
I don't think this is the correct way to use repr(transparent); it should only be used for e.g. ABI guarantees.
|
|
I think I picked that up from a video somewhere. I removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a feeling the main bottleneck on the grid is IO, so I added a log entry. It also gives a more granular overview of the progress in a single bidegree, since there's one line for every signature now. I feel this is important now that every bidegree takes several hours. It's also future-proof w.r.t. #99, since we are generic over a
T: Write