Add Mahowald invariant example #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aergus
force-pushed
the
example-mahowald_invariant
branch
from
965d059 to
10b4ffa
Compare
|
Sorry for just leaving this here. We should probably merge this... |
JoeyBF
approved these changes
Jun 30, 2023
|
I'll add that the lint error is just due to a new version of clippy and the selenium error is the same as in #121 |
aergus
force-pushed
the
example-mahowald_invariant
branch
from
50638c2 to
78ff9bb
Compare
Co-authored-by: Joey Beauvais-Feisthauer <[email protected]>
aergus
force-pushed
the
example-mahowald_invariant
branch
from
78ff9bb to
6167a5e
Compare
|
Thanks for the feedback. I'm trying to refactor the code to make it more testable and will comment here again when it's done (or I give up). |
`RP_-k_inf`s are not compatible with Nassau's algorithm.
|
I've added a test with a few cases (and "fixed" the incompatibility with the |
|
Looks great to me! @hoodmane anything to add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example that computes algebraic Mahowald invariants, showcasing
ResolutionHomomorphismin particular.