Fix selenium but only partially #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Sep 25, 2023
Co-authored-by: Hood Chatham <[email protected]>
hoodmane
approved these changes
Sep 25, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2023
* Give more time to firefox driver * Make sure this is what fixes the tests * Make suggested changes Co-authored-by: Hood Chatham <[email protected]> --------- Co-authored-by: Hood Chatham <[email protected]>
github-actions bot
added a commit
to JoeyBF/sseq
that referenced
this pull request
Sep 26, 2023
* Give more time to firefox driver * Make sure this is what fixes the tests * Make suggested changes Co-authored-by: Hood Chatham <[email protected]> --------- Co-authored-by: Hood Chatham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #121 but in an unsatisfying way. This seems to fix the flakiness of the selenium tests, but while inspecting the logs I noticed that the wasm/local/local-concurrent steps were actually all testing the wasm server. The servers compiled by cargo would exit when they noticed that port 8080 was busy, because the previous
make serve-wasmwas still running. Adding akill %1toext.yaml, so that the servers are stopped in between steps, only made more issues crop up. I feel like this should be fixed but as a separate PR