Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PotionEffect retrieval error from DataContainer #1969

Closed
wants to merge 1 commit into from
Closed

Fix PotionEffect retrieval error from DataContainer #1969

wants to merge 1 commit into from

Conversation

ImMorpheus
Copy link
Contributor

@ImMorpheus ImMorpheus commented Jul 2, 2018 •
edited
Loading

Fix #1276

~qa

@ImMorpheus ImMorpheus requested a review from gabizou as a code owner July 2, 2018 17:17
@XakepSDK
Copy link
Contributor

XakepSDK commented Jul 2, 2018

@gabizou you should do something with this. This is second time i seen that type of errors.

@gabizou
Copy link
Member

gabizou commented Jul 2, 2018

@gabizou you should do something with this. This is second time i seen that type of errors.

I'll give you another chance at rephrasing that statement.

@limbo-app limbo-app added status: needs review a code review is needed status: needs testing does this run, does it solve the issue etc labels Jul 2, 2018
@kashike kashike removed the status: needs review a code review is needed label Jul 3, 2018
@Aaron1011
Copy link
Contributor

Merged in b834524.

@Aaron1011 Aaron1011 closed this Jul 3, 2018
@Aaron1011 Aaron1011 mentioned this pull request Jul 3, 2018
Closed
@ImMorpheus ImMorpheus deleted the fix/potion-retrieval branch July 7, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@kashike kashike kashike approved these changes

@gabizou gabizou gabizou approved these changes

Assignees
No one assigned
Labels
status: needs testing does this run, does it solve the issue etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ImMorpheus @XakepSDK @gabizou @Aaron1011 @kashike @parlough @limbo-app