Add support for Linux scriptslog path #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub const SCRIPTSLOG_FILE_NAME: &str = "scriptslog.txt"; | ||
| pub const LINUX_STEAM_PFX_PATH: &str = ".local/share/Steam/steamapps/compatdata/292030/pfx/drive_c/users/steamuser/Documents"; // it's ok to use forward slashes because this is Linux-specific |
There was a problem hiding this comment.
Are you sure this path is universal for all linux steam installations? Maybe a better solution would be to just allow passing a custom path to the scriptslog in the CLI?
There was a problem hiding this comment.
This is the standard Steam prefix location and I think we could keep this as default, but yeah I think it would be better for people with a custom Steam location or a GOG installation if we allowed user input. Good thinking.
There was a problem hiding this comment.
Should I close this PR and add the option for custom path instead then?
There was a problem hiding this comment.
I think it would be better if you added commits to this PR rather than rewrite it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Linux
scriptslog.txtunder the Steam prefix (non-functional with GOG yet). Anything other than Linux or Windows throws and unimplemented exception.