Cancelation realloc and current member state check/retain #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Will change this to be ProposalVoteV2 |
ogmedia
commented
Jun 21, 2024
programs/squads_multisig_program/src/instructions/proposal_vote.rs
Outdated
Show resolved
Hide resolved
ogmedia
commented
Jun 21, 2024
programs/squads_multisig_program/src/instructions/proposal_vote.rs
Outdated
Show resolved
Hide resolved
ogmedia
commented
Jun 21, 2024
|
@vovacodes @bguillaumat the updates slated here for the realloc introduce some duplications, but mainly because i'm not sure what we're thinking for the future. Since this is already an edge case, i'm thinking we maybe change the account contect to ProposalCancel, and use that in the proposal_cancel_v2 ix. Then we can rip out all of the approve/reject from it. Lmk. |
ogmedia
commented
Jun 21, 2024
programs/squads_multisig_program/src/instructions/proposal_vote.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancellation is blocked if new threshold exceeds space when proposal was first created. It's an edge case, but this will block the ability to cancel and thus reclaim rent. We propose adding a proposal_cancel_v2 for this specific realloc, but that requires a system_program account, thus adding a new account context.