feat(spending_limits): allow spending limits for non-members #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After dog-fooding Spending Limits both in Squads and Fuse and having a deep discussion with the protocol team, we suggest to drop the requirement for the Spending Limits to only be usable by the members of the multisig.
This allows for perfectly valid workflows that are pretty clanky right now, for example creating an SL for the fee relayer (currently this requires adding the relayer as a member to the multisig with no permissions).
The potential risks are dangling SLs that are created for random keys and now forgotten, but in our opinion it's a case for proper multisig housekeeping - making sure your SLs are up to date and deleted when not needed anymore