Execute optimizations #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ogmedia
commented
Aug 15, 2024
•
ogmedia
commented
- We convert seeds to a vec, only to be reduced/collected as a slice again. This would simply pass the slice originally.
- Ephemeral/signer seeds don't change per loop iteration, moved the logic outside of the loop.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xRigel-squads
pushed a commit
that referenced
this pull request
Nov 22, 2024
* feat(spending_limits): allow spending limits for non-members * fix(multisig_add_member) Additional check for duplication upon member config action. * fix(multisig_add_spending_limit) In the case of a controlled multisig (with config_authority), we run a duplicate check on the member keys in the spending limit. * fix(close_account) * updated account context for vault closing to incorporate missing proposal account (non init) * feat(config_transaction_accounts_close,vault_transaction_accounts_close): allow closing stale tx accounts with no proposal * feat(batch_accounts_close): allow closing stale tx accounts with no proposal --------- Co-authored-by: Vladimir Guguiev <[email protected]> * fix(cancellation_realloc) * Cancelation realloc and current member state check/retain * added comment about realloc * move new vote logic to a v2 ix to preserve backwards compatibility * new proposal cancel instruction (v2) * new account context labeled as ProposalCancel specifically * add the retain old member keys to existing cancel logic * Execute optimizations (#110) * fix(vault_seeds): removed iterations * pass vault seed slice directly * fix(execute-tx-message): optimization - moved signer seed iterations out of loop * chore(typo): fixed Fixed "threshold" typo * fix: Heap Optimization (#111) * heap optimization/removing inefficient clone * add: comments around explicit usage and consequences of `core::mem::take` --------- Co-authored-by: slg <[email protected]> * chore(cancel-tests): added test and sdk methods for cancel realloc * chore(cancel-test): verify account size changed * Feat: Incremental Transaction Uploading (#113) * wip: incremental tx uploading * add: incremental tx uploading ixns * generate sdk & add tests - createbuffer & extend passing* - createVaultTxFromBuffer failing with "Program Failed to Complete" * base case tests passing * add comments for clarity * expose buffer close & add test * add: extra tests -- buffer creation and extension * add: tests for transactionBufferClose * fix: uncomment tests * fix: space allocation buffer creation * add: additional helper for buffer size * add: buffer deserialization checks * dummy vercel commit * feat: tx buffer example & out of memory example --------- Co-authored-by: Joey Meere <[email protected]> * Feat: Custom Bump Allocator (#114) * wip: incremental tx uploading * add: incremental tx uploading ixns * generate sdk & add tests - createbuffer & extend passing* - createVaultTxFromBuffer failing with "Program Failed to Complete" * base case tests passing * add comments for clarity * expose buffer close & add test * add: extra tests -- buffer creation and extension * add: tests for transactionBufferClose * fix: uncomment tests * fix: space allocation buffer creation * add: additional helper for buffer size * add: buffer deserialization checks * dummy vercel commit * feat: tx buffer example & out of memory example * initial commit * feat: flipped bump allocator on its head * feat: heap tests, buffer chunking util + refactor * remove: heap test ix & add: allocator docs * rm: heapTest testing suite * add: script for running anchor test in detach * revert: Cargo.toml anchor-lang change * linting: cargo fmt --------- Co-authored-by: Joey Meere <[email protected]> * WIP * refactor: vault_transaction_from_buffer * feat: wrap context for createFromBuffer * add: comments * chore: fmt * refactor: wrap ProposalVote context inside ProposalCancelV2 * fix: typo * fix: comments from certora preliminary findings * fix: transaction_buffer_close seed constraints * fix: confusing semantics * fix: buffer vec size * small comment fixes * refactor: lamport mutation into system transfer * feat: u8 for buffer seeding * fix: bind transaction_buffer seeds to creator * remove: current member check for transaction_buffer_close * fix: creator check on vault_tx_create_from_buffer * remove: multisig mut in transaction_buffer instructions * remove: testing code from allocator * fix: tests * fix: MAX_BUFFER_SIZE saturation in invariant check * remove: heap testing instruction * deprecate: multisig_create * refactor: sdk for multisig_create deprecation * refactor: tests for multisig_create deprecation * add: custom deprecation error * tests: uncomment and fix * (tests)fix: broken tests from multisig_create deprecation * bump: program version to 2.1.0 * fix(program): space calculation transaction_buffer * bump: Anchor.toml solana-cli to 1.18.16 * bump(idl): to 2.1.0 * modify: max transaction_buffer size * fix(tests): accomodate new max buffer size * fix(tests): custom heap --------- Co-authored-by: Vladimir Guguiev <[email protected]> Co-authored-by: Orion <[email protected]> Co-authored-by: Joey Meere <[email protected]> Co-authored-by: Iceomatic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.