Code Deduplication & Cleanup #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: comments from certora preliminary findings
Certora Audit Findings: Fix transaction_buffer_close seed constraints
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the following instructions:
vault_transaction_create_from_bufferproposal_cancel_v2It deduplicates the business logic copied from
vault_transaction_createandProposalVote::ProposalCancelby re-using the respective contexts from those instructions. This is done in favor of copy-pasting the business logic as that introduces unnecessary code bloating.The result is that
vault_transaction_create_from_bufferandproposal_cancel_v2now call intovault_transaction_createandProposalVote::ProposalCancelrespectively instead of copy-pasting their contents