Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto retry message on connection failure #1856

Closed
wants to merge 83 commits into from
Closed

Auto retry message on connection failure #1856

wants to merge 83 commits into from

Commits on Jun 7, 2021

  1. autoretry with hooks

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ad90509 View commit details
    Browse the repository at this point in the history

  2. RequestMessage Implementation 

    Allow SetWriteTime for sync messages as well
    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    4e9e97b View commit details
    Browse the repository at this point in the history

  3. Add hook to requestFailed on connection exception

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    433da7f View commit details
    Browse the repository at this point in the history

  4. experimenting with the main retry loop to be handling time outs as well

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8a533f6 View commit details
    Browse the repository at this point in the history

  5. Making requestfailed as internal for now, will expose it later after … 

    …design is solidified
    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ae9e35a View commit details
    Browse the repository at this point in the history

  6. improve message timeout while waiting for connection restore to complete

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    754ba69 View commit details
    Browse the repository at this point in the history

  7. Remove unused variable

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    9ff40ef View commit details
    Browse the repository at this point in the history

  8. Removing unused commandflags for now

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    fd1f1da View commit details
    Browse the repository at this point in the history

  9. undo csproj change to match upstream

    @deepakverma
    deepakverma committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    415bcdf View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Creating a connectiontry configurationoption and command flags

    @deepakverma
    deepakverma committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    889520c View commit details
    Browse the repository at this point in the history

  2. connection,ultipexer changes to handle message retry

    @deepakverma
    deepakverma committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    2ed46cd View commit details
    Browse the repository at this point in the history

  3. Message retry

    @deepakverma
    deepakverma committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    97d96cc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. ensure no retry is set as default

    @deepakverma
    deepakverma committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    1f7c27c View commit details
    Browse the repository at this point in the history

  2. whoops, cleaning up stale code and rety should be default as null

    @deepakverma
    deepakverma committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    bb1a1d1 View commit details
    Browse the repository at this point in the history

  3. typo

    @deepakverma
    deepakverma committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    9e815d3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into autoretry 

    # Conflicts:
#	src/StackExchange.Redis/PhysicalBridge.cs
    @deepakverma
    deepakverma committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    78e6910 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Merge branch 'main' into pr/1755

    @NickCraver
    NickCraver committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c7c6b8e View commit details
    Browse the repository at this point in the history

  2. making Retryqueuelength nullable

    @deepakverma
    deepakverma committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    d6b4d30 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. dropping onconnectionrestore from retry config option

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    623d731 View commit details
    Browse the repository at this point in the history

  2. renaming Retry => CommandRetry

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    7cd57b8 View commit details
    Browse the repository at this point in the history

  3. to honor redirent option specified by the user, do not reset noredirect

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    ed1be50 View commit details
    Browse the repository at this point in the history

  4. incorporating feedback on PR

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    906289f View commit details
    Browse the repository at this point in the history

  5. do not retry admin commands

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    fd3407a View commit details
    Browse the repository at this point in the history

  6. unifiying commandretry and commandlfags

    @deepakverma
    deepakverma committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    ea5091a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. fixed failing test

    @deepakverma
    deepakverma committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    97c957a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. IRetry

    @deepakverma
    deepakverma committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    cc9f6da View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. introducing FailedMessage class to make IRetry shouldretry extensible 

    support for string based IRetry configuration option
    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    f4f994f View commit details
    Browse the repository at this point in the history

  2. separating out retrymanager

    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    127c25c View commit details
    Browse the repository at this point in the history

  3. first attempt to decouple iretrymanager from mux

    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5968359 View commit details
    Browse the repository at this point in the history

  4. moving out timeout check to retrymanager

    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e9f0c0f View commit details
    Browse the repository at this point in the history

  5. separating out Retrymanager and being explicit on policy depends on q… 

    …ueue
    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    c2cb2e4 View commit details
    Browse the repository at this point in the history

  6. reverting the rename

    @deepakverma
    deepakverma committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    50802fd View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. rnaming methods

    @deepakverma
    deepakverma committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    df3e08b View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. improving failedmessage

    @deepakverma
    deepakverma committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    819eb0b View commit details
    Browse the repository at this point in the history

  2. Make messageretrymanager internal for now

    @deepakverma
    deepakverma committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    c5a89aa View commit details
    Browse the repository at this point in the history

  3. making MessageRetryQueueManager as internal for now

    @deepakverma
    deepakverma committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    4cb0175 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. 1. retryqueuelength 

    2. onerror
    @deepakverma
    deepakverma committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    fa12e0b View commit details
    Browse the repository at this point in the history

  2. few renames

    @deepakverma
    deepakverma committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    14d54f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. cleaning up failedmessage

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    20f7bf4 View commit details
    Browse the repository at this point in the history

  2. starting unit test

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    e93d836 View commit details
    Browse the repository at this point in the history

  3. using IInternalConnectionmultiplexer

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2524fc7 View commit details
    Browse the repository at this point in the history

  4. Handle exception

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5e5edb9 View commit details
    Browse the repository at this point in the history

  5. handleResult implementation

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6631146 View commit details
    Browse the repository at this point in the history

  6. handle timeout on sync for retry

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    e02e04b View commit details
    Browse the repository at this point in the history

  7. can handle redisexception only and first unit test

    @deepakverma
    deepakverma committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2a9d182 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. making commandretryqueuemanager testable

    @deepakverma
    deepakverma committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    6018207 View commit details
    Browse the repository at this point in the history

  2. CommandRetryQueueManager tests

    @deepakverma
    deepakverma committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c5e2080 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. mux should retry internal commands but not call shouldretry

    @deepakverma
    deepakverma committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a941dbc View commit details
    Browse the repository at this point in the history

  2. test to cover exception being thrown while processing the message

    @deepakverma
    deepakverma committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    9e3d515 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. integration test

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3523397 View commit details
    Browse the repository at this point in the history

  2. integrationTest

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    83c78bf View commit details
    Browse the repository at this point in the history

  3. command override tests

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3afa54f View commit details
    Browse the repository at this point in the history

  4. Simplifying RetryPolicy

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    c326927 View commit details
    Browse the repository at this point in the history

  5. DefaultREtryPolicy

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    87e1fb1 View commit details
    Browse the repository at this point in the history

  6. refactored out failedcommand

    @deepakverma
    deepakverma committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    b615eec View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. updated summary and few renames

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    a067467 View commit details
    Browse the repository at this point in the history

  2. code cleanup

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    50bd6df View commit details
    Browse the repository at this point in the history

  3. this should likely fix the incorrect diff with main

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    febffca View commit details
    Browse the repository at this point in the history

  4. fixing another diff that should have not been there

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    bfdfb3b View commit details
    Browse the repository at this point in the history

  5. no op where it doesn't retry timeouts

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    83bbd87 View commit details
    Browse the repository at this point in the history

  6. merge

    @deepakverma
    deepakverma committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    bceb859 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Merge branch 'main' of https://github.com/StackExchange/StackExchange… 

    ….Redis into StackExchange-main

# Conflicts:
#	src/StackExchange.Redis/ConnectionMultiplexer.cs
#	src/StackExchange.Redis/Message.cs
    @deepakverma
    deepakverma committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    41cc755 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Expose retry policy config as RetryCommandsOnReconnect

    @philon-msft
    philon-msft committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    335bef6 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Minor unit test improvements

    @philon-msft
    philon-msft committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    06bb176 View commit details
    Browse the repository at this point in the history

  2. Minor syntax cleanup

    @philon-msft
    philon-msft committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    e0da9c4 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from philon-msft/master 

    Make ConfigOption specifically about "RetryCommandsOnReconnect"
    @deepakverma
    deepakverma authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    2d3b860 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Merge branch 'autoretry' into autoretry2

    @deepakverma
    deepakverma committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    0a165bd View commit details
    Browse the repository at this point in the history

  2. moving methods from mux to retrypolicy

    @deepakverma
    deepakverma committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    d29a7fc View commit details
    Browse the repository at this point in the history

  3. fix conditions in IsMessageREtriable and make it simpler for reading

    @deepakverma
    deepakverma committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    7ef0a5b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #4 from deepakverma/autoretry2 

    Autoretry2
    @deepakverma
    deepakverma authored Aug 13, 2021
    Configuration menu
    Copy the full SHA
    dc6cfa1 View commit details
    Browse the repository at this point in the history

  5. cleaning up debug code

    @deepakverma
    deepakverma committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    a0c26de View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2021

  1. Throw in case retrypolicy is not set and pass failing test

    @deepakverma
    deepakverma committed Aug 15, 2021
    Configuration menu
    Copy the full SHA
    0ab8bf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Initial refactor/renaming 

    Simplifying things a bit as discussed on call - talking in code!
    Nick Craver committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    f68655d View commit details
    Browse the repository at this point in the history

  2. Fix ref issue 

    Not in love with this approach of a Func exposed, but we need something that solves things - let's chat!
    Nick Craver committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c857c4b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Move love

    Nick Craver committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8189e7a View commit details
    Browse the repository at this point in the history

  2. Cleanup

    Nick Craver committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    570b060 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Cleanup internals

    @NickCraver
    NickCraver committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c48ff6d View commit details
    Browse the repository at this point in the history

  2. Simplify

    @NickCraver
    NickCraver committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    8d9d0fe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into command-retry

    @NickCraver
    NickCraver committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    664ede2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Revert "Cleanup internals" 

    This reverts commit c48ff6d.
    @NickCraver
    NickCraver committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3cc22ea View commit details
    Browse the repository at this point in the history

  2. Add note on why this internal visibility is needed

    @NickCraver
    NickCraver committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    62d215a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into command-retry

    @NickCraver
    NickCraver committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    f4a3a54 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Command Retry: Changes and Simplifications (#1857) 

    See #1856 (comment) for a discussion here.

Note: this DOES NOT remove the `PhysicalBridge` backlog queue...because there are more issues discovered there. Will write up on the main PR.
    @NickCraver
    NickCraver authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    da3e55d View commit details
    Browse the repository at this point in the history