Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AZURE_PRIVATE_DNS: Rename module to conform to Go styleguide #2697

Merged
merged 2 commits into from
Dec 6, 2023
Merged

AZURE_PRIVATE_DNS: Rename module to conform to Go styleguide #2697

merged 2 commits into from
Dec 6, 2023

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Dec 6, 2023 •
edited
Loading

staticcheck reports:

providers/azure_private_dns/auditrecords.go:1:1: should not use underscores in package names (ST1003)
providers/azure_private_dns/azurePrivateDnsProvider.go:1:1: should not use underscores in package names (ST1003)

I should have caught this during the original submission. The provider is still called AZURE_PRIVATE_DNS as far as the users know.

Also ran go generate ./... to fix providers.md

CC @matthewmgamble for visibility.

@tlimoncelli tlimoncelli merged commit 3b6643b into master Dec 6, 2023
14 checks passed
@tlimoncelli tlimoncelli deleted the tlim_apd branch December 6, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlimoncelli