Adjust test to use runner.yaml file over the symlink
#6259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
The symlink is not registered in pants. So far, this is the first time something has tried to access that file. So, just use the actual file instead of the symlink
cognifloyd
force-pushed
the
runner-yaml-symlink
branch
from
014fbce to
c7e4543
Compare
cognifloyd
requested review from
nzlosh,
mamercad,
guzzijones,
amanda11 and
a team
cognifloyd
changed the title
runner.yaml file over the symlink
guzzijones
approved these changes
Oct 8, 2024
nzlosh
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extracted from #6202 where I'm working on getting pants to run our tests with pytest.
The
runner.yamlsymlink is not registered in pants. So far, the test in this PR is the first file I've found that accesses that symlink. So, this PR makes the test just use the actual file instead of the symlink.I put this commit in it's own PR because it doesn't fit with any of the other changes, and to see if anyone knows of a reason for the
runner.yamlsymlinks. The symlinks seem pointless to me, so I don't want to rely on them. Is there anything else that relies on these symlinks?