Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGD8-2616: Remove video module after #967

Merged
merged 1 commit into from
Dec 21, 2023
Merged

SGD8-2616: Remove video module after #967

merged 1 commit into from
Dec 21, 2023

Conversation

SvenVdv
Copy link
Contributor

@SvenVdv SvenVdv commented Dec 21, 2023

Description

  • Video embed module adds an after element which has styling that's already been added by our styleguide, so we remove the double

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have updated the gent_base CHANGELOG accordingly.

@SvenVdv SvenVdv requested a review from lennartvava December 21, 2023 11:01
@lennartvava lennartvava merged commit dc50090 into 6.x Dec 21, 2023
@lennartvava lennartvava deleted the feature/SGD8-2616-6.x branch December 21, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartvava lennartvava lennartvava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvenVdv @lennartvava