Skip to content

Commit

Permalink
Remove MagicAndre stuff - cannot get it to work?
Browse files Browse the repository at this point in the history
  • Loading branch information
@StanDeMan
StanDeMan committed May 3, 2022
1 parent cc38232 commit 851c105
Show file tree
Hide file tree
Showing 2 changed files with 588 additions and 613 deletions.
Loading

9 comments on commit 851c105

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is not working? Simply add 2 Targetframeworks (3.1 and 6.0) to a csproj, now debug fails, with my fix it works.

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only buggy thing is the IsStandalone property of SdkCatalogItem. The 100, 200, 300 shows feature levels, not if bundled with VS or not. @StanDeMan remove this property or let it always return true.

@StanDeMan
Copy link
Owner Author

@StanDeMan StanDeMan commented on 851c105 May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicAndre1981 I merged everything as I started to push the 64Bit stuff to bring it to live.
IActiveDebugFrameworkServices isn't got referenced. Don't know why? Let me get my 64Bit stuff to run than I'll try to put your stuff in again. Maybe I'll need your help.

@StanDeMan
Copy link
Owner Author

@StanDeMan StanDeMan commented on 851c105 May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicAndre1981 I don't like the sdk-catalog.json file. All the versions have to be handeled and Microsoft is producing quite a lot of patches for some time now. But there seems not to be a news feed sending back all .NET Core versions. Only the MS version pages are available.
64Bit seems to work now - have to test more. I update the sdk catalog soon and than I'll try to get your stuff running again.
What can I do to get the IActiveDebugFrameworkServices resolved?

@MagicAndre1981
Copy link

@MagicAndre1981 MagicAndre1981 commented on 851c105 May 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanDeMan the IActiveDebugFrameworkServices comes from a package of the VS pre-release feed that I added to the NuGet.config because the public Microsoft.VisualStudio.ProjectSystem.Managed package misses this Interface.

Maybe Microsoft changed the feed urls 🤔 🤷‍♂️

There is already a request to publish a stable package and this is ignored by Microsoft (as always)

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanDeMan have you tried again to get it work?

@StanDeMan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicAndre1981 I'm working on 64Bit integration. Do you know if there is an Nuget available - I haven't found one. If there is one I can integrate again. Threw the IsStandalone out - this is really not needed - as you mentioned.

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicAndre1981 I'm working on 64Bit integration. Do you know if there is an Nuget available - I haven't found one.

I opened my PR code and the nuget is restored fine in a fresh VM with VS2022 17.3P1.

PackageSignatureVerificationLog: PackageIdentity: Microsoft.VisualStudio.ProjectSystem.Managed.17.0.3-beta1-11028-06 Source: https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json PackageSignatureValidity: True

So the package is found in vs-impl feed at https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json

IActiveDebugFrameworkServices

So your nuget is somehow broken (you maybe only select nuget.org in nuget UI and not "All") and to avoid this even Microsoft people asked to publish stable packages to nuget.org, but it is ignored as you see in my linked issue.

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft will never publish new VS packages on nuget and delist the old ones soon. According to them you need to fix your nuget issues with the feeds. So check your firewall/router/av software and allow the azure sites.

Please sign in to comment.