Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix append not supported between LargeBinaryColumn and BinaryColumn in primary key encoder #33548

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[BugFix] Fix append not supported between LargeBinaryColumn and BinaryColumn in primary key encoder #33548

merged 1 commit into from
Oct 24, 2023

Conversation

decster
Copy link
Contributor

@decster decster commented Oct 24, 2023

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@decster
[BugFix] Fix append not supportted between LargeBinaryColumn and Bina…
028c72d 
…ryColumn in primary key encoder

Signed-off-by: Binglin Chang <[email protected]>
@chaoyli chaoyli changed the title [BugFix] Fix append not supportted between LargeBinaryColumn and BinaryColumn in primary key encoder [BugFix] Fix append not supported between LargeBinaryColumn and BinaryColumn in primary key encoder Oct 24, 2023
@decster decster enabled auto-merge (squash) October 24, 2023 08:42
@github-actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@decster decster merged commit bc1de10 into StarRocks:main Oct 24, 2023
47 checks passed
@github-actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 3 / 11 (27.27%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/primary_key_encoder.cpp 3 11 27.27% [437, 438, 439, 440, 443, 444, 445, 446]

decster added a commit that referenced this pull request Oct 25, 2023
@decster
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
9ac413b 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 25, 2023
@decster @wanpengfei-git
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
c5a277d 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Oct 26, 2023
@decster
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
53abff9 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 26, 2023
@decster @wanpengfei-git
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
de787fe 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Oct 26, 2023
@decster
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
355ef17 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 26, 2023
@decster @wanpengfei-git
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
7fc4ead 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Oct 26, 2023
@decster
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
55709ba 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Oct 27, 2023
@decster
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
252a183 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 27, 2023
@decster @wanpengfei-git
[BugFix] Fix append not supported between LargeBinaryColumn and Binar…
d9d8f33 
…yColumn in primary key encoder (#33548)

Fix append is not supported between LargeBinaryColumn and BinaryColumn, so avoid using them in primary key encoder.

Signed-off-by: Binglin Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoyli chaoyli chaoyli approved these changes

@sevev sevev sevev approved these changes

Assignees

@decster decster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decster @sevev @chaoyli