Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] show persistent index disk cost in be_tablets (backport #35615) #36022

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 29, 2023

This is an automatic backport of pull request #35615 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

We can't get the persistent index disk usage from system table now.
Add each tablet's persistent index disk usage `INDEX_DISK` to `be_tablets`.

```
mysql> select * from be_tablets where tablet_id = 10121\G
*************************** 1. row ***************************
       BE_ID: 10004
    TABLE_ID: 10119
PARTITION_ID: 10118
   TABLET_ID: 10121
 NUM_VERSION: 4
 MAX_VERSION: 6
 MIN_VERSION: 4
  NUM_ROWSET: 1
     NUM_ROW: 5
   DATA_SIZE: 710
   INDEX_MEM: 119
 CREATE_TIME: 1700701817
       STATE: RUNNING
        TYPE: PRIMARY
    DATA_DIR: /home/disk5/luoyixin/starrocks-4/starrocks/output/be/storage
    SHARD_ID: 48
 SCHEMA_HASH: 1872891624
  INDEX_DISK: 152
1 row in set (0.02 sec)
```

(cherry picked from commit 956f397)
Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/system/information/BeTabletsSystemTable.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

fail : 6 / 13 (46.15%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/schema_scanner/schema_be_tablets_scanner.cpp 0 4 00.00% [95, 173, 179, 190]
🔵 src/storage/tablet_updates.cpp 6 9 66.67% [2751, 2753, 3904]

auto-merge was automatically disabled November 30, 2023 23:59

Rebase merges are not allowed on this repository

@chaoyli chaoyli merged commit 37f1f80 into branch-3.2 Nov 30, 2023
27 of 29 checks passed
@chaoyli chaoyli deleted the mergify/bp/branch-3.2/pr-35615 branch November 30, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants