Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Merge orc type checking logic in OrcMapping #36127

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[Enhancement] Merge orc type checking logic in OrcMapping #36127

merged 3 commits into from
Nov 30, 2023

Conversation

Smith-Cruise
Copy link
Contributor

@Smith-Cruise Smith-Cruise commented Nov 30, 2023 •
edited
Loading

Why I'm doing:

What I'm doing:
Make code cleaner and cp to branch-2.5, branch-2.5 didn't have type-checking logic, will occur BE crashed.

Fixes #16371 not cherry-picked

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 10 / 12 (83.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/formats/orc/orc_mapping.cpp 10 12 83.33% [93, 326]

@Youngwb Youngwb merged commit 53a8082 into StarRocks:main Nov 30, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 30, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 30, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 30, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Nov 30, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@Smith-Cruise @mergify
[Enhancement] Merge orc type checking logic in OrcMapping (#36127)
4345df5 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 53a8082)
@mergify mergify bot mentioned this pull request Nov 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@Smith-Cruise @mergify
[Enhancement] Merge orc type checking logic in OrcMapping (#36127)
751ef6f 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 53a8082)
@mergify mergify bot mentioned this pull request Nov 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@Smith-Cruise @mergify
[Enhancement] Merge orc type checking logic in OrcMapping (#36127)
c38567d 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 53a8082)
@mergify mergify bot mentioned this pull request Nov 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@Smith-Cruise @mergify
[Enhancement] Merge orc type checking logic in OrcMapping (#36127)
4ad4783 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 53a8082)

# Conflicts:
#	be/src/formats/orc/orc_mapping.cpp
#	be/test/formats/orc/orc_chunk_reader_test.cpp
@mergify mergify bot mentioned this pull request Nov 30, 2023
Closed
@Smith-Cruise Smith-Cruise deleted the fix-orc-crash branch November 30, 2023 09:04
@Smith-Cruise Smith-Cruise mentioned this pull request Nov 30, 2023
Merged
22 tasks
dirtysalt pushed a commit that referenced this pull request Nov 30, 2023
@mergify @Smith-Cruise
[Enhancement] Merge orc type checking logic in OrcMapping (backport #…
3dadc8a 
…36127) (#36167)

Co-authored-by: Smith Cruise <[email protected]>
dirtysalt pushed a commit that referenced this pull request Nov 30, 2023
@mergify @Smith-Cruise
[Enhancement] Merge orc type checking logic in OrcMapping (backport #…
f3e8757 
…36127) (#36166)

Co-authored-by: Smith Cruise <[email protected]>
stephen-shelby pushed a commit that referenced this pull request Nov 30, 2023
@mergify @Smith-Cruise
[Enhancement] Merge orc type checking logic in OrcMapping (backport #…
d415564 
…36127) (#36165)

Co-authored-by: Smith Cruise <[email protected]>
lipenglin pushed a commit to lipenglin/starrocks that referenced this pull request Dec 2, 2023
@Smith-Cruise @lipenglin
[Enhancement] Merge orc type checking logic in OrcMapping (StarRocks#…
fdaab7e 
…36127)

Signed-off-by: Smith Cruise <[email protected]>
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
@Smith-Cruise @dingxin-tech
[Enhancement] Merge orc type checking logic in OrcMapping (StarRocks#…
6c56ba7 
…36127)

Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: 鼎昕 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@dirtysalt dirtysalt dirtysalt approved these changes

@Youngwb Youngwb Youngwb approved these changes

Assignees

@Smith-Cruise Smith-Cruise

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smith-Cruise @dirtysalt @Youngwb @wanpengfei-git