[Enhancement] Support profile for only big query (2) (backport #39855) #40207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #39855 done by Mergify.
Cherry-pick of a3758df has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com
In the previous pr #33825, we've supported the profile only for big query with the session variable
big_query_profile_second_threshold
Unfortunately, for some of our uses, most of the queries can be done within 200ms with a latency spike over 400ms, we cannot catch the slow query(400ms) with the session variable mentioned above.
What I'm doing & Behavior Change
big_query_profile_second_threshold
with typeint
.big_query_profile_threshold
with typestring
, it can support time duration like1s
/500ms
/15m
etc.This change won't lead to compatible problem when performing grey upgrading.
big_query_profile_second_threshold
.big_query_profile_second_threshold
big_query_profile_threshold
corresponding to the previous configuration manually.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: