-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](3/n) Support fast schema evolution in shared data mode #42737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astralidea
previously approved these changes
Mar 19, 2024
sduzh
force-pushed
the
enhancement/use-schema-id
branch
from
March 19, 2024 11:57
d743874
to
a56f20b
Compare
@Mergifyio rebase |
sduzh
force-pushed
the
enhancement/use-schema-id
branch
from
March 20, 2024 02:21
a56f20b
to
b910a73
Compare
✅ Branch has been successfully rebased |
@Mergifyio rebase |
Before the fast schema evolution is implemented, the schema of a MaterializedIndex will not change, and the materialized index ID can be used as the unique identifier of its schema. In the upcoming fast schema evolution, the schema of a materialized index may change, and the materialized index id can no longer be used as the unique identifier of the schema. This PR changes the use of index id to schema id. Signed-off-by: Alex Zhu <[email protected]>
✅ Branch has been successfully rebased |
sduzh
force-pushed
the
enhancement/use-schema-id
branch
from
March 22, 2024 08:50
b910a73
to
c4107f0
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 14 / 14 (100.00%) file detail
|
@kevincai @xiangguangyxg PTAL |
sevev
approved these changes
Mar 25, 2024
Astralidea
approved these changes
Mar 25, 2024
@mergify backport branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
) Signed-off-by: Alex Zhu <[email protected]> (cherry picked from commit 3c7f9db) # Conflicts: # be/test/storage/lake/delta_writer_test.cpp # be/test/storage/lake/partial_update_test.cpp
41 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 31, 2024
…kport #42737) (#49075) Signed-off-by: xiangguangyxg <[email protected]> Co-authored-by: Alex Zhu <[email protected]> Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Before the fast schema evolution is implemented, the schema of a MaterializedIndex will not change, and the materialized index ID can be used as the unique identifier of its schema. In the upcoming fast schema evolution, the schema of a materialized index may change, and the materialized index id can no longer be used as the unique identifier of the schema.
What I'm doing:
Changes the use of index id to schema id.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: