Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](3/n) Support fast schema evolution in shared data mode #42737

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Mar 18, 2024

Why I'm doing:

Before the fast schema evolution is implemented, the schema of a MaterializedIndex will not change, and the materialized index ID can be used as the unique identifier of its schema. In the upcoming fast schema evolution, the schema of a materialized index may change, and the materialized index id can no longer be used as the unique identifier of the schema.

What I'm doing:

Changes the use of index id to schema id.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned sduzh Mar 18, 2024
@sduzh sduzh enabled auto-merge (squash) March 18, 2024 10:59
Astralidea
Astralidea previously approved these changes Mar 19, 2024
@sduzh
Copy link
Contributor Author

sduzh commented Mar 20, 2024

@Mergifyio rebase

@sduzh sduzh force-pushed the enhancement/use-schema-id branch from a56f20b to b910a73 Compare March 20, 2024 02:21
Copy link
Contributor

mergify bot commented Mar 20, 2024

rebase

✅ Branch has been successfully rebased

@sduzh
Copy link
Contributor Author

sduzh commented Mar 20, 2024

@wyb @kevincai PTAL

@sduzh
Copy link
Contributor Author

sduzh commented Mar 22, 2024

@Mergifyio rebase

Before the fast schema evolution is implemented, the schema of a
MaterializedIndex will not change, and the materialized index ID
can be used as the unique identifier of its schema. In the
upcoming fast schema evolution, the schema of a materialized index
may change, and the materialized index id can no longer be used
as the unique identifier of the schema. This PR changes the use
of index id to schema id.

Signed-off-by: Alex Zhu <[email protected]>
Copy link
Contributor

mergify bot commented Mar 22, 2024

rebase

✅ Branch has been successfully rebased

@sduzh sduzh force-pushed the enhancement/use-schema-id branch from b910a73 to c4107f0 Compare March 22, 2024 08:50
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/lake_tablets_channel.cpp 2 2 100.00% []
🔵 be/src/storage/lake/async_delta_writer.h 1 1 100.00% []
🔵 be/src/storage/lake/tablet.cpp 2 2 100.00% []
🔵 be/src/storage/lake/delta_writer.h 1 1 100.00% []
🔵 be/src/storage/lake/tablet_manager.cpp 4 4 100.00% []
🔵 be/src/storage/lake/delta_writer.cpp 4 4 100.00% []

@sduzh
Copy link
Contributor Author

sduzh commented Mar 25, 2024

@kevincai @xiangguangyxg PTAL

@sduzh sduzh merged commit 3c7f9db into StarRocks:main Mar 25, 2024
43 checks passed
@sduzh sduzh deleted the enhancement/use-schema-id branch March 25, 2024 07:41
@xiangguangyxg
Copy link
Contributor

@mergify backport branch-3.2

Copy link
Contributor

mergify bot commented Jul 29, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 29, 2024
)

Signed-off-by: Alex Zhu <[email protected]>
(cherry picked from commit 3c7f9db)

# Conflicts:
#	be/test/storage/lake/delta_writer_test.cpp
#	be/test/storage/lake/partial_update_test.cpp
wanpengfei-git pushed a commit that referenced this pull request Jul 31, 2024
…kport #42737) (#49075)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: Alex Zhu <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants