-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support online optimize table #43747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meegoo
force-pushed
the
online_optimize
branch
3 times, most recently
from
April 8, 2024 19:17
c16063b
to
e29d447
Compare
meegoo
force-pushed
the
online_optimize
branch
2 times, most recently
from
April 10, 2024 08:29
a872872
to
1c8ae7e
Compare
meegoo
changed the title
[Feature] Support online optimize table
[Enhancement] Support online optimize table
Apr 10, 2024
meegoo
force-pushed
the
online_optimize
branch
4 times, most recently
from
April 15, 2024 13:02
b8f0d49
to
fcaff5a
Compare
meegoo
force-pushed
the
online_optimize
branch
3 times, most recently
from
May 8, 2024 13:06
b9d3704
to
44932a2
Compare
wyb
reviewed
May 9, 2024
fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java
Outdated
Show resolved
Hide resolved
meegoo
force-pushed
the
online_optimize
branch
4 times, most recently
from
May 15, 2024 12:15
ec1fd30
to
95442a6
Compare
wyb
reviewed
May 20, 2024
fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/alter/OnlineOptimizeJobV2.java
Outdated
Show resolved
Hide resolved
wyb
reviewed
May 28, 2024
fe/fe-core/src/main/java/com/starrocks/transaction/DatabaseTransactionMgr.java
Show resolved
Hide resolved
meegoo
force-pushed
the
online_optimize
branch
2 times, most recently
from
May 31, 2024 09:22
0a6354f
to
6438402
Compare
Signed-off-by: meegoo <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
[FE Incremental Coverage Report]✅ pass : 496 / 579 (85.66%) file detail
|
[BE Incremental Coverage Report]✅ pass : 194 / 233 (83.26%) file detail
|
wyb
approved these changes
Jun 17, 2024
wangruin
approved these changes
Jun 17, 2024
Seaven
approved these changes
Jun 17, 2024
nshangyiming
approved these changes
Jun 17, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: meegoo <[email protected]> (cherry picked from commit 16acc23) # Conflicts: # be/src/agent/publish_version.cpp # be/src/exec/CMakeLists.txt # be/src/exec/tablet_sink_sender.cpp # be/src/exec/tablet_sink_sender.h # be/src/exec/write_combined_txn_log.cpp # be/src/exec/write_combined_txn_log.h # be/src/runtime/lake_tablets_channel.cpp # fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java # fe/fe-core/src/main/java/com/starrocks/task/PublishVersionTask.java # gensrc/proto/internal_service.proto # gensrc/thrift/AgentService.thrift # gensrc/thrift/DataSinks.thrift
42 tasks
meegoo
added a commit
that referenced
this pull request
Aug 20, 2024
Signed-off-by: meegoo <[email protected]> Co-authored-by: meegoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently, the Optimize Table redistributes data at the granularity of partitions. If new data is ingest into a partition during the optimization process, conflicts can arise. The default strategy is to prioritize ingestion, causing the optimization job for that partition to fail. This makes it impossible for Optimize Table to handle:
What I'm doing:
Support Online Optimize Table, allowing Optimize Table and DML operations to run concurrently without conflict.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: