-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add storage-related profiles for load #45560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
May 13, 2024
banmoy
force-pushed
the
storage_metric
branch
2 times, most recently
from
May 16, 2024 03:44
5d16753
to
653c8af
Compare
banmoy
force-pushed
the
storage_metric
branch
2 times, most recently
from
May 29, 2024 00:19
d340eaa
to
bac3201
Compare
banmoy
changed the title
[Feature] Add storage-related profiles for load
[Enhancement] Add storage-related profiles for load
May 29, 2024
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
wyb
reviewed
Jun 19, 2024
wyb
reviewed
Nov 27, 2024
banmoy
force-pushed
the
storage_metric
branch
2 times, most recently
from
November 30, 2024 11:23
c860e09
to
6b5ea01
Compare
wyb
approved these changes
Dec 2, 2024
banmoy
force-pushed
the
storage_metric
branch
from
December 2, 2024 04:31
38d99ac
to
92d392f
Compare
meegoo
approved these changes
Dec 2, 2024
banmoy
force-pushed
the
storage_metric
branch
from
December 3, 2024 02:09
92d392f
to
648a5d8
Compare
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
banmoy
force-pushed
the
storage_metric
branch
from
December 3, 2024 06:00
648a5d8
to
586d35e
Compare
trueeyu
approved these changes
Dec 3, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 272 / 281 (96.80%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Need storage metrics in the load profile to know why the load is slow if the bottleneck is at the storage
What I'm doing:
Fix #46373
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: