Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add storage-related profiles for load #45560

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented May 13, 2024

Why I'm doing:

Need storage metrics in the load profile to know why the load is slow if the bottleneck is at the storage

What I'm doing:

  • For primary/peer tablets, there are following metrics
    • the number/cost of methods for DeltaWriter write/close/commit
    • the statistics about memtable including the number/cost of sort, agg, flush
    • for primary tablets, also includes the time to sync segments to secondary replica
    • the pending time of tasks in the queue such as async delta writer task, flush task, segment replica task
  • For secondary tablets, there are following metrics
    • the number/cost of methods for DeltaWriter add_segment/commit
    • the statistics about segment flush

Fix #46373

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@banmoy banmoy requested review from a team as code owners May 13, 2024 13:39
@banmoy banmoy marked this pull request as draft May 13, 2024 13:39
@mergify mergify bot assigned banmoy May 13, 2024
@banmoy banmoy force-pushed the storage_metric branch 2 times, most recently from 5d16753 to 653c8af Compare May 16, 2024 03:44
@banmoy banmoy force-pushed the storage_metric branch 2 times, most recently from d340eaa to bac3201 Compare May 29, 2024 00:19
@banmoy banmoy marked this pull request as ready for review May 29, 2024 00:29
@banmoy banmoy changed the title [Feature] Add storage-related profiles for load [Enhancement] Add storage-related profiles for load May 29, 2024
Copy link
Contributor

mergify bot commented May 29, 2024

rerun

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Copy link
Contributor

mergify bot commented May 29, 2024

run

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

be/src/storage/segment_replicate_executor.cpp Outdated Show resolved Hide resolved
be/src/storage/memtable_flush_executor.cpp Outdated Show resolved Hide resolved
@banmoy banmoy force-pushed the storage_metric branch 2 times, most recently from c860e09 to 6b5ea01 Compare November 30, 2024 11:23
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Copy link

github-actions bot commented Dec 3, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 3, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Dec 3, 2024

[BE Incremental Coverage Report]

pass : 272 / 281 (96.80%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/memtable_flush_executor.cpp 7 9 77.78% [94, 95]
🔵 be/src/storage/delta_writer.cpp 21 25 84.00% [640, 641, 642, 643]
🔵 be/src/storage/memtable.cpp 16 18 88.89% [356, 357]
🔵 be/src/runtime/local_tablets_channel.cpp 124 125 99.20% [1010]
🔵 be/src/runtime/lake_tablets_channel.cpp 4 4 100.00% []
🔵 be/src/storage/delta_writer.h 5 5 100.00% []
🔵 be/src/storage/segment_flush_executor.cpp 14 14 100.00% []
🔵 be/src/storage/segment_replicate_executor.cpp 22 22 100.00% []
🔵 be/src/storage/segment_replicate_executor.h 2 2 100.00% []
🔵 be/src/storage/memtable.h 15 15 100.00% []
🔵 be/src/exec/tablet_sink.cpp 1 1 100.00% []
🔵 be/src/exec/tablet_sink_index_channel.cpp 1 1 100.00% []
🔵 be/src/storage/async_delta_writer.cpp 1 1 100.00% []
🔵 be/src/runtime/load_channel.cpp 37 37 100.00% []
🔵 be/src/storage/segment_flush_executor.h 2 2 100.00% []

@wyb wyb merged commit 01c4145 into StarRocks:main Dec 4, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add storage-related profiles for load
5 participants