Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve kafka group authorization failed message in routine load #46136

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented May 23, 2024

Why I'm doing:

ErrorReason{errCode = 4, msg='Job failed to fetch all current partition with error [err: Broker: Topic authorization failed, BE: TNetworkAddress(hostname:10.0.7.100, port:8060)]'}

[2024-05-23 16:19:37] [task id: cc6fc6c9-e9e6-4a3f-ad3a-190a1f10a633] [txn id: -1] previous task aborted because of FindCoordinator response error: Group authorization failed.

What I'm doing:

ErrorReason{errCode = 4, msg='Job failed to fetch all current partition with error [failed to get kafka topic meta, err: Broker: Topic authorization failed. You should add READ permission for this topic: users in topic ACLs, BE: TNetworkAddress(hostname:10.0.7.100, port:8060)]'}

[2024-07-11 02:53:30] [task id: 364c7947-c884-446f-9d1e-b1eeafb1325f] [txn id: -1] previous task aborted because of kafka consume failed, err: Fetch from broker 1 failed: Broker: Topic authorization failed. You should add READ permission for this topic: users in topic ACLs

[2024-07-11 02:55:41] [task id: bee6bf6f-9606-411f-b341-2611ee943c00] [txn id: -1] previous task aborted because of kafka consume failed, err: FindCoordinator response error: Group authorization failed.. You should add or modify the consumer group 'wyb_consume_group_3' with READ permission for this topic: users in consumer group ACLs and set the routine load job with `property.group.id` property

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner May 23, 2024 09:26
@mergify mergify bot assigned wyb May 23, 2024
@wyb wyb force-pushed the routine_load_group_authorization branch from 1a3306b to e1a2308 Compare May 23, 2024 09:32
@jaogoy
Copy link
Contributor

jaogoy commented May 24, 2024

I suggest to use following error message:
xxx, You could set the Routine Load job with property.group.id property, the default property.group.id is ${label}-${uuid} (which is xxx for this job), and set the proper consumer groups ACLs in your kafka cluster.

@wyb wyb force-pushed the routine_load_group_authorization branch 2 times, most recently from d7706e6 to c66dde0 Compare July 11, 2024 08:55
@wyb wyb requested review from jaogoy and meegoo July 11, 2024 08:58
@wyb wyb force-pushed the routine_load_group_authorization branch from c66dde0 to 682ba98 Compare July 11, 2024 09:45
@wyb wyb force-pushed the routine_load_group_authorization branch from 682ba98 to 569b675 Compare July 11, 2024 10:11
jaogoy
jaogoy previously approved these changes Jul 11, 2024
Signed-off-by: wyb <[email protected]>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 8 / 30 (26.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/routine_load/data_consumer.cpp 8 30 26.67% [272, 273, 274, 275, 277, 278, 280, 281, 282, 283, 287, 288, 293, 385, 386, 387, 388, 389, 392, 393, 451, 452]

@wanpengfei-git wanpengfei-git merged commit 3ac2074 into StarRocks:main Jul 17, 2024
46 of 47 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 17, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jul 17, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jul 17, 2024
Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jul 17, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 17, 2024
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 17, 2024
wanpengfei-git pushed a commit that referenced this pull request Jul 17, 2024
zhangheihei pushed a commit to zhangheihei/starrocks that referenced this pull request Jul 18, 2024
wyb added a commit that referenced this pull request Jul 19, 2024
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants