-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] List Partition For AMV(Part 2): Support list partition for asynchronous materialized view with non-nullable partition columns #46680
Conversation
a5cd3d6
to
73e5c67
Compare
7daffaf
to
68c2189
Compare
…llable partition columns Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
cfe2a34
to
a967fe5
Compare
Signed-off-by: shuming.li <[email protected]> fix bugs Signed-off-by: shuming.li <[email protected]>
Quality Gate passedIssues Measures |
Map<String, PListCell> mvItems) { | ||
// This synchronization method has a one-to-one correspondence | ||
// between the base table and the partition of the mv. | ||
Map<String, PListCell> adds = diffList(baseItems, mvItems); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any risk to be a time-consuming step when table or mv has a large number of partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. It's possible to be time consuming.
I will add a benchmark to figure out how slow it's, and do some optimization later in the next pr.
[FE Incremental Coverage Report]✅ pass : 363 / 445 (81.57%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
…asynchronous materialized view with non-nullable partition columns (#46680) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ea0e0f) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/RangePartitionDiffer.java # test/lib/sr_sql_lib.py
…asynchronous materialized view with non-nullable partition columns (backport #46680) (#47712) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
…asynchronous materialized view with non-nullable partition columns (StarRocks#46680) Signed-off-by: shuming.li <[email protected]>
Why I'm doing:
What I'm doing:
Fixes #46087
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: